[dpdk-dev] [PATCH v4 05/11] eal: replace rte_panic instances in eventdev

Arnon Warshavsky arnon at qwilt.com
Fri Apr 20 15:17:24 CEST 2018


Ok. Thanks

On Thu, Apr 19, 2018 at 8:26 PM, Kevin Traynor <ktraynor at redhat.com> wrote:

> On 04/19/2018 07:01 AM, Arnon Warshavsky wrote:
> > replace panic calls with log and retrun value.
> >
> > --
> > v4 - fix split literal strings in log messages
> >
> > Signed-off-by: Arnon Warshavsky <arnon at qwilt.com>
> > ---
> >  lib/librte_eventdev/rte_eventdev_pmd_pci.h  | 8 +++++---
> >  lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +++++---
> >  2 files changed, 10 insertions(+), 6 deletions(-)
> >
> > diff --git a/lib/librte_eventdev/rte_eventdev_pmd_pci.h
> b/lib/librte_eventdev/rte_eventdev_pmd_pci.h
> > index 8fb6138..dad2182 100644
> > --- a/lib/librte_eventdev/rte_eventdev_pmd_pci.h
> > +++ b/lib/librte_eventdev/rte_eventdev_pmd_pci.h
> > @@ -66,9 +66,11 @@
> >                                               RTE_CACHE_LINE_SIZE,
> >                                               rte_socket_id());
> >
> > -             if (eventdev->data->dev_private == NULL)
> > -                     rte_panic("Cannot allocate memzone for private "
> > -                                     "device data");
> > +             if (eventdev->data->dev_private == NULL) {
> > +                     RTE_LOG(CRIT, EAL, "%s(): Cannot allocate memzone
> for private device data",
> > +                             __func__);
> > +                     return -1;
>
> return -ENOMEM
>
> > +             }
> >       }
> >
> >       eventdev->dev = &pci_dev->device;
> > diff --git a/lib/librte_eventdev/rte_eventdev_pmd_vdev.h
> b/lib/librte_eventdev/rte_eventdev_pmd_vdev.h
> > index 8c64a06..b7c08fa 100644
> > --- a/lib/librte_eventdev/rte_eventdev_pmd_vdev.h
> > +++ b/lib/librte_eventdev/rte_eventdev_pmd_vdev.h
> > @@ -61,9 +61,11 @@
> >                                               RTE_CACHE_LINE_SIZE,
> >                                               socket_id);
> >
> > -             if (eventdev->data->dev_private == NULL)
> > -                     rte_panic("Cannot allocate memzone for private
> device"
> > -                                     " data");
> > +             if (eventdev->data->dev_private == NULL) {
> > +                     RTE_LOG(CRIT, EAL, "%s(): Cannot allocate memzone
> for private device data",
> > +                             __func__);
> > +                     return NULL;
> > +             }
> >       }
> >
> >       return eventdev;
> >
>
>


-- 

*Arnon Warshavsky*
*Qwilt | work: +972-72-2221634 | mobile: +972-50-8583058 | arnon at qwilt.com
<arnon at qwilt.com>*


More information about the dev mailing list