[dpdk-dev] [PATCH 1/2] net/dpaa: non supported offloads are ignored with warning

Stephen Hemminger stephen at networkplumber.org
Fri Apr 20 17:20:45 CEST 2018


On Fri, 20 Apr 2018 16:15:40 +0530
Sunil Kumar Kori <sunil.kori at nxp.com> wrote:

>  	dpaa_eth_dev_info(dev, &dev_info);
>  	if (((~(dev_info.rx_offload_capa) & rx_offloads) != 0)) {
> -		DPAA_PMD_ERR("Some Rx offloads are not supported "
> +		DPAA_PMD_WARN("Some Rx offloads are not supported "
>  			"requested 0x%" PRIx64 " supported 0x%" PRIx64,

The if statement has more parens than necessary.

Please don't break error messages across lines, it is better to have a long source
line since it allows users to use tools like grep to search for error messages.


More information about the dev mailing list