[dpdk-dev] [PATCH] app/testpmd: fix testpmd failure due to RSS offload check
Ferruh Yigit
ferruh.yigit at intel.com
Tue Apr 24 16:39:35 CEST 2018
On 4/24/2018 3:18 PM, Qi Zhang wrote:
> After add RSS hash offload check, default rss_hf will fail on
> devices that not support all bits, the patch take rss_hf as
> a suggest value and only set bits that device supported base on
> rte_eth_dev_get_info.
>
> Fixes: 527624c663f8 ("ethdev: add supported hash function check")
> Signed-off-by: Qi Zhang <qi.z.zhang at intel.com>
> ---
> app/test-pmd/testpmd.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index d6da41927..af3fc5388 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -2265,13 +2265,16 @@ init_port_config(void)
> {
> portid_t pid;
> struct rte_port *port;
> + struct rte_eth_dev_info dev_info;
>
> RTE_ETH_FOREACH_DEV(pid) {
> port = &ports[pid];
> port->dev_conf.fdir_conf = fdir_conf;
> if (nb_rxq > 1) {
> + rte_eth_dev_info_get(pid, &dev_info);
> port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL;
> - port->dev_conf.rx_adv_conf.rss_conf.rss_hf = rss_hf;
> + port->dev_conf.rx_adv_conf.rss_conf.rss_hf =
> + rss_hf & dev_info.flow_type_rss_offloads;
"rss_hf" is a global variable, not per port. Adrien's patch [1] made that it has
been updated by "port config all rss ..." command, so that value can change.
Also Xueming's patch did it will set "0" if "default" parameter used [2], like
"port config all rss default"
So not sure if rss_hf is reliable at this point.
What do you think using dev_info.flow_type_rss_offloads directly?
[1] 75d5493eb302 ("app/testpmd: fix RSS flow action configuration")
[2] 8c1f4aff92a6 ("app/testpmd: new parameter for port config all RSS command")
> } else {
> port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL;
> port->dev_conf.rx_adv_conf.rss_conf.rss_hf = 0;
>
More information about the dev
mailing list