[dpdk-dev] [PATCH v7 11/11] devtools: prevent new instances of rte_panic and rte_exit

Stephen Hemminger stephen at networkplumber.org
Wed Apr 25 01:15:46 CEST 2018


On Wed, 25 Apr 2018 01:03:20 +0200
Thomas Monjalon <thomas at monjalon.net> wrote:

> 25/04/2018 00:52, Stephen Hemminger:
> > On Wed, 25 Apr 2018 01:16:53 +0300
> > Arnon Warshavsky <arnon at qwilt.com> wrote:
> >   
> > > This patch adds a new function that is called
> > > per every checked patch,
> > > and alerts for new instances of rte_panic/rte_exit.
> > > The check excludes comments, and alerts in the case
> > > of a positive balance between additions and removals.
> > > 
> > > Signed-off-by: Arnon Warshavsky <arnon at qwilt.com>  
> > 
> > Why not just mark the functions as deprecated with compiler attribute.  
> 
> No, the applications can use these functions.

Yeah, fighting against that would be hard. They always seemed like internal
functions.


More information about the dev mailing list