[dpdk-dev] [PATCH v7 08/11] eal: replace rte_panic instances in interrupts thread

Burakov, Anatoly anatoly.burakov at intel.com
Wed Apr 25 11:14:18 CEST 2018


On 24-Apr-18 11:16 PM, Arnon Warshavsky wrote:
> replace panic calls with log and return value.
> Thread function removes the noreturn attribute.
> 
> Signed-off-by: Arnon Warshavsky <arnon at qwilt.com>
> ---

Just a general comment - i'm not too familiar with this code, but it 
looks like all of these failures will only happen on thread init. Can we 
make sure it starts?

You can use similar approach to Olivier's (recently merged) thread 
affinity patches, with pthread barriers etc. to ensure the thread has 
initialized properly, pthread_cancel() it if it didn't, and return -1 on 
thread init.

-- 
Thanks,
Anatoly


More information about the dev mailing list