[dpdk-dev] [PATCH] app/testpmd: update start log to be less verbose

Ferruh Yigit ferruh.yigit at intel.com
Wed Apr 25 16:15:09 CEST 2018


A per port per queue log is too verbose with multiple port/queue log is
longer than full screen, make it less verbose:
- Reduced log to only first queue of the port, as a sample
- Merged a few lines
- Indent queue logs for readability

The log becomes as following after update:

testpmd> start tx_first
io packet forwarding - ports=2 - cores=1 - streams=8 - NUMA support enabled, MP over anonymous pages disabled
Logical Core 1 (socket 0) forwards packets on 8 streams:
  RX P=0/Q=0 (socket 0) -> TX P=1/Q=0 (socket 0) peer=02:00:00:00:00:01
  RX P=0/Q=1 (socket 0) -> TX P=1/Q=1 (socket 0) peer=02:00:00:00:00:01
  RX P=0/Q=2 (socket 0) -> TX P=1/Q=2 (socket 0) peer=02:00:00:00:00:01
  RX P=0/Q=3 (socket 0) -> TX P=1/Q=3 (socket 0) peer=02:00:00:00:00:01
  RX P=1/Q=0 (socket 0) -> TX P=0/Q=0 (socket 0) peer=02:00:00:00:00:00
  RX P=1/Q=1 (socket 0) -> TX P=0/Q=1 (socket 0) peer=02:00:00:00:00:00
  RX P=1/Q=2 (socket 0) -> TX P=0/Q=2 (socket 0) peer=02:00:00:00:00:00
  RX P=1/Q=3 (socket 0) -> TX P=0/Q=3 (socket 0) peer=02:00:00:00:00:00

  io packet forwarding packets/burst=32
  nb forwarding cores=1 - nb forwarding ports=2
  port 0: RX queue number: 4 Tx queue number: 4
  Rx offloads=0x1000 Tx offloads=0x0
  RX queue: 0
    RX desc=0 - RX free threshold=32
    RX threshold registers: pthresh=8 hthresh=8  wthresh=0
    RX Offloads=0x1000
  TX queue: 0
    TX desc=0 - TX free threshold=32
    TX threshold registers: pthresh=32 hthresh=0  wthresh=0
    TX RS bit threshold=32
    TX offloads=0x0
  port 1: RX queue number: 4 Tx queue number: 4
  Rx offloads=0x1000 Tx offloads=0x0
  RX queue: 0
    RX desc=0 - RX free threshold=32
    RX threshold registers: pthresh=8 hthresh=8  wthresh=0
    RX Offloads=0x1000
  TX queue: 0
    TX desc=0 - TX free threshold=32
    TX threshold registers: pthresh=32 hthresh=0  wthresh=0
    TX RS bit threshold=32
    TX offloads=0x0

Fixes: 266f28b91e34 ("app/testpmd: enable per queue configure")
Cc: qi.z.zhang at intel.com

Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
---

Hi Qi,

If you are agree with the patch I can squash into original patch.

btw, desc numbers are zero, "TX desc=0","RX desc=0", is this correct?
---
 app/test-pmd/config.c | 35 ++++++++++++++++-------------------
 1 file changed, 16 insertions(+), 19 deletions(-)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 216a7eb4e..a5bfda140 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1776,43 +1776,40 @@ rxtx_config_display(void)
 		uint16_t *nb_tx_desc = &ports[pid].nb_tx_desc[0];
 
 		/* per port config */
-		printf("  port %d:\n", (unsigned int)pid);
-		printf("  Rx offloads=0x%"PRIx64"\n",
-				ports[pid].dev_conf.rxmode.offloads);
+		printf("  port %d: RX queue number: %d Tx queue number: %d\n",
+				(unsigned int)pid, nb_rxq, nb_txq);
 
-		printf("  Tx offloads=0x%"PRIx64"\n",
+		printf("  Rx offloads=0x%"PRIx64" Tx offloads=0x%"PRIx64"\n",
+				ports[pid].dev_conf.rxmode.offloads,
 				ports[pid].dev_conf.txmode.offloads);
 
-		printf("  RX queue number: %d\n", nb_rxq);
-
-		/* per rx queue config */
-		for (qid = 0; qid < nb_rxq; qid++) {
+		/* per rx queue config only for first queue to be less verbose */
+		for (qid = 0; qid < 1; qid++) {
 			printf("  RX queue: %d\n", qid);
-			printf("  RX desc=%d - RX free threshold=%d\n",
+			printf("    RX desc=%d - RX free threshold=%d\n",
 				nb_rx_desc[qid], rx_conf[qid].rx_free_thresh);
-			printf("  RX threshold registers: pthresh=%d hthresh=%d "
+			printf("    RX threshold registers: pthresh=%d hthresh=%d "
 				" wthresh=%d\n",
 				rx_conf[qid].rx_thresh.pthresh,
 				rx_conf[qid].rx_thresh.hthresh,
 				rx_conf[qid].rx_thresh.wthresh);
-			printf("  RX Offloads=0x%"PRIx64"\n",
+			printf("    RX Offloads=0x%"PRIx64"\n",
 				rx_conf[qid].offloads);
 		}
 
-		printf("  Tx queue number: %d\n", nb_txq);
-
-		/* per tx queue config */
-		for (qid = 0; qid < nb_txq; qid++) {
+		/* per tx queue config only for first queue to be less verbose */
+		for (qid = 0; qid < 1; qid++) {
 			printf("  TX queue: %d\n", qid);
-			printf("  TX desc=%d - TX free threshold=%d\n",
+			printf("    TX desc=%d - TX free threshold=%d\n",
 				nb_tx_desc[qid], tx_conf[qid].tx_free_thresh);
-			printf("  TX threshold registers: pthresh=%d hthresh=%d "
+			printf("    TX threshold registers: pthresh=%d hthresh=%d "
 				" wthresh=%d\n",
 				tx_conf[qid].tx_thresh.pthresh,
 				tx_conf[qid].tx_thresh.hthresh,
 				tx_conf[qid].tx_thresh.wthresh);
-			printf("  TX RS bit threshold=%d\n", tx_conf->tx_rs_thresh);
-			printf("  TX offloads=0x%"PRIx64"\n",
+			printf("    TX RS bit threshold=%d\n",
+				tx_conf->tx_rs_thresh);
+			printf("    TX offloads=0x%"PRIx64"\n",
 				tx_conf[qid].offloads);
 		}
 	}
-- 
2.14.3



More information about the dev mailing list