[dpdk-dev] [PATCH] test/eal_flags: Optimize memory flags test

Thomas Monjalon thomas at monjalon.net
Wed Apr 25 19:07:28 CEST 2018


Hi,

Your patch has been forgotten for months.
Do not hesitate to ping if no reply.

I have a question below.

06/02/2018 03:21, Phil Yang:
> --- a/test/test/test_eal_flags.c
> +++ b/test/test/test_eal_flags.c
> -#define SOCKET_MEM_STRLEN (RTE_MAX_NUMA_NODES * 10)
> +#define SOCKET_MEM_STRLEN (RTE_MAX_NUMA_NODES * 20)

Why the above change?

> @@ -1138,10 +1138,11 @@ test_memory_flags(void)
> -	int i, num_sockets = get_number_of_sockets();
> +	int i, num_sockets = RTE_MIN(get_number_of_sockets(),
> +			RTE_MAX_NUMA_NODES);
>  #endif
>  
> -	if (num_sockets <= 0 || num_sockets > RTE_MAX_NUMA_NODES) {
> +	if (num_sockets <= 0) {
>  		printf("Error - cannot get number of sockets!\n");
>  		return -1;
>  	}
> 







More information about the dev mailing list