[dpdk-dev] [PATCH v3 6/6] doc: advertise bucket mempool driver
Thomas Monjalon
thomas at monjalon.net
Thu Apr 26 00:04:27 CEST 2018
25/04/2018 23:56, Thomas Monjalon:
> Usually it is better to update the release notes in the main patch
> implementing the feature (probably the first one in this case).
> You can also update it step by step in several patches.
>
> 25/04/2018 18:32, Andrew Rybchenko:
> > --- a/doc/guides/rel_notes/release_18_05.rst
> > +++ b/doc/guides/rel_notes/release_18_05.rst
> > @@ -147,7 +147,15 @@ New Features
> > compatible with virtio 0.95 and 1.0. This driver registers ifcvf vDPA driver
> > to vhost lib, when virtio connected, with the help of the registered vDPA
> > driver the assigned VF gets configured to Rx/Tx directly to VM's virtio
> > - vrings.
>
> Removing this last word is probably a mistake.
>
> > +
> > +* **Added bucket mempool driver.**
> > +
> > + Added bucket mempool driver which provides a way to allocate contiguous
> > + block of objects.
> > + Number of objects in the block depends on how many objects fit in
> > + RTE_DRIVER_MEMPOOL_BUCKET_SIZE_KB memory chunk which is build time option.
> > + The number may be obtained using rte_mempool_ops_get_info() API.
> > + Contiguous blocks may be allocated using rte_mempool_get_contig_blocks() API.
Please add this feature at the beginning of the list (as the first one).
If possible, I would prefer you rebase on top of the mainline
(looks to be next-net here).
Thanks and sorry for nit-picking, I'm testing your stamina :)
More information about the dev
mailing list