[dpdk-dev] [PATCH] app/bbdev: dynamic lib support

De Lara Guarch, Pablo pablo.de.lara.guarch at intel.com
Thu Apr 26 16:29:45 CEST 2018



> -----Original Message-----
> From: Chalupnik, KamilX
> Sent: Thursday, April 26, 2018 3:24 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>; dev at dpdk.org
> Cc: Mokhtar, Amr <amr.mokhtar at intel.com>
> Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> 
> Hi Pablo
> 
> > -----Original Message-----
> > From: De Lara Guarch, Pablo
> > Sent: Thursday, April 26, 2018 3:22 PM
> > To: Chalupnik, KamilX <kamilx.chalupnik at intel.com>; dev at dpdk.org
> > Cc: Mokhtar, Amr <amr.mokhtar at intel.com>
> > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> >
> >
> >
> > > -----Original Message-----
> > > From: Chalupnik, KamilX
> > > Sent: Thursday, April 26, 2018 1:48 PM
> > > To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>;
> > > dev at dpdk.org
> > > Cc: Mokhtar, Amr <amr.mokhtar at intel.com>
> > > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support
> > >
> > > Hi Pablo
> > >
> >
> > ...
> >
> > > > > Ok, we will deliver such changes in patches for next release.
> > > > > Are you ok with that?
> > > >
> > > > I think this change should not take a long time. The sooner we do
> > > > it, the better, as there might be more people using this in the future.
> > > > I can send the patch for you, so you can focus on other changes,
> > > > and then you can see if it is fine for you.
> > > >
> > > > Thanks,
> > > > Pablo
> > >
> > > Ok. I will add this change to our patchset as well.
> >
> > In order to make sure that users can still use the previous name, to
> > avoid breaking Backwards compatibility, you modify DRIVER_NAME with
> > the new name and then use RTE_PMD_REGISTER_ALIAS(DRIVER_NAME,
> > turbo_sw); This way, both names can be used, but you should update the
> > docs to use the new name.
> >
> > Thanks,
> > Pablo
> 
> 
> Thanks for suggestions :)
> I've already prepared a changes. Just one question. Can I prepare separate patch
> based on the 13 patchset? Is that ok? Such solution will be cleaner in my opinion.
> 

Sure, this change should be independent from the other ones. You don't have to add all patches in the same patchset (when they are not logically related).

Thanks,
Pablo

> Best regards,
> Kamil
> 



More information about the dev mailing list