[dpdk-dev] [PATCH] lcore: make semantics of lcore role function more intuitive

Stephen Hemminger stephen at networkplumber.org
Thu Apr 26 17:38:42 CEST 2018


On Thu, 26 Apr 2018 14:42:31 +0100
Anatoly Burakov <anatoly.burakov at intel.com> wrote:

> rte_lcore_has_role() returns 0 if role of lcore matches requested
> role. The return value of the API is confusing, and this is a known
> problem with a deprecation notice announcing the change to more
> intuitive semantics:
> 
> Commit 064518f68d48 ("doc: announce EAL API change to lcore role function")
> Cc: erik.g.carrillo at intel.com
> 
> Implement changes announced in the deprecation notice, and remove it.
> Also, fix usages of this API to reflect the change. Control thread patches
> expected new behavior and were broken before, now they are fixed as well.
> 
> Fixes: d651ee4919cd ("eal: set affinity for control threads")
> Cc: olivier.matz at 6wind.com
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov at intel.com>

It would make more sense if rte_lcore_has_role returned a bool


More information about the dev mailing list