[dpdk-dev] [PATCH v9 08/10] eal: replace rte_panic instances in ethdev
Arnon Warshavsky
arnon at qwilt.com
Thu Apr 26 23:38:38 CEST 2018
> > -void __rte_experimental
> > +int __rte_experimental
> > rte_eth_dev_owner_delete(const uint64_t owner_id)
> > {
> > uint16_t port_id;
> > + int error;
>
> it's inconsistent that this function returns the error code from
> rte_eth_dev_shared_data_prepare() and all these other functions return -1
>
> >
> > - rte_eth_dev_shared_data_prepare();
> > + error = rte_eth_dev_shared_data_prepare();
> > + if (error != 0)
> > + return error;
> >
>
Thanks Kevin, that's a valid point.
Since the function itself returns either 0 or -1 I will align this one
instance with the rest of the calls.
thanks
/Arnon
More information about the dev
mailing list