[dpdk-dev] [PATCH v9 10/10] devtools: prevent new instances of rte_panic and rte_exit

Arnon Warshavsky arnon at qwilt.com
Thu Apr 26 23:57:56 CEST 2018


On Thu, Apr 26, 2018 at 7:08 PM, Kevin Traynor <ktraynor at redhat.com> wrote:

> I think the first line of the commit msg ^^^ should change as it no
> longer prevents but just warns
>
> Actually the return value did not change, only the warning text did.
I would rather keep the word 'prevents' as an intention declaration that
puts the fact that a panic is undesired first, and the technical ability of
a maintainer to allow it second.
This is just in terms of how one positions the usage of panic.



> >
>
> Seems to drop the patch name if it finds a match


Not sure I understand what you meant here. Can you please elaborate?

Thanks
/Arnon


More information about the dev mailing list