[dpdk-dev] [PATCH v9 00/10] eal: replace calls to rte_panic and refrain from new instances

Arnon Warshavsky arnon at qwilt.com
Fri Apr 27 18:31:47 CEST 2018


On Fri, Apr 27, 2018, 17:22 Thomas Monjalon <thomas at monjalon.net> wrote:

> 26/04/2018 08:20, Arnon Warshavsky:
> > The purpose of this patch series is to cleanup the library code
> > from paths that end up aborting the process,
> > and move to checking error values, in order to allow the running process
> > perform an orderly teardown or other mitigation of the event.
> >
> > This patch modifies the majority of rte_panic calls
> > under lib and drivers, and replaces them with a log message
> > and an error return code according to context,
> > that can be propagated up the call stack.
> >
> > - Focus was given to the dpdk initialization path
> > - Some of the panic calls within drivers were left in place where
> >   the call is from within an interrupt or calls that are
> >   on the data path,where there is no simple applicative
> >   route to propagate the error to temination.
> >   These should be handled by the driver maintainers..
> > - local void functions with no api were changed to retrun a value
> >   where needed
> > - No change took place in example and test files
> > - No change took place for debug assertions calling panic
> > - A new function was added to devtools/checkpatches.sh
> >   in order to prevent new additions of calls to rte_panic
> >   under lib and drivers.
> >
> > Keep calm and don't panic
>
> What is the status of this patchset?
> It seems not ready for RC1 (today).
> I don't want to push it in RC2 because it changes too many things.
> So it's today or wait for 18.08. What do you think?
>
> The last patch for check tooling can be separated and pushed at anytime.
>

Yes,unfortunately its 18.08.I am away the entire weekend from any means of
getting  the code fixed, so only on Sunday I will split the last patch from
the rest.
Should I put the tooling patch as a new set and refer both patchsets to the
current v9?

>
>
>


More information about the dev mailing list