[dpdk-dev] [v2, 5/6] eventdev: add event crypto adapter to meson build system

[Jerin Jacob]

-----Original Message-----
> Date: Mon, 30 Apr 2018 11:21:38 +0000
> From: "Gujjar, Abhinandan S" <abhinandan.gujjar at intel.com>
> To: Jerin Jacob <jerin.jacob at caviumnetworks.com>
> CC: "hemant.agrawal at nxp.com" <hemant.agrawal at nxp.com>,
>  "akhil.goyal at nxp.com" <akhil.goyal at nxp.com>, "dev at dpdk.org"
>  <dev at dpdk.org>, "Vangati, Narender" <narender.vangati at intel.com>, "Rao,
>  Nikhil" <nikhil.rao at intel.com>, "Eads, Gage" <gage.eads at intel.com>
> Subject: RE: [v2,5/6] eventdev: add event crypto adapter to meson build
>  system
> 
> 
> 
> > -----Original Message-----
> > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com]
> > Sent: Sunday, April 29, 2018 9:55 PM
> > To: Gujjar, Abhinandan S <abhinandan.gujjar at intel.com>
> > Cc: hemant.agrawal at nxp.com; akhil.goyal at nxp.com; dev at dpdk.org; Vangati,
> > Narender <narender.vangati at intel.com>; Rao, Nikhil <nikhil.rao at intel.com>;
> > Eads, Gage <gage.eads at intel.com>
> > Subject: Re: [v2,5/6] eventdev: add event crypto adapter to meson build system
> > 
> > -----Original Message-----
> > > Date: Tue, 24 Apr 2018 18:13:26 +0530
> > > From: Abhinandan Gujjar <abhinandan.gujjar at intel.com>
> > > To: jerin.jacob at caviumnetworks.com, hemant.agrawal at nxp.com,
> > > akhil.goyal at nxp.com, dev at dpdk.org
> > > CC: narender.vangati at intel.com, abhinandan.gujjar at intel.com,
> > > nikhil.rao at intel.com, gage.eads at intel.com
> > > Subject: [v2,5/6] eventdev: add event crypto adapter to meson build
> > > system
> > > X-Mailer: git-send-email 1.9.1
> > >
> > > Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar at intel.com>
> > > ---
> > >  lib/librte_eventdev/meson.build | 8 +++++---
> > >  1 file changed, 5 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/lib/librte_eventdev/meson.build
> > > b/lib/librte_eventdev/meson.build
> > 
> > Separate patch is not required for meson build. Have it in the same patch for
> > make based build and ADD each files as when it added in the patch.
> Should I add changes related to " lib/librte_eventdev/meson.build" as part of crypto adapter implementation?
> Or you recommend the changes in "eventdev pmd" patch?

IMO, You can add in second patch where your implementation gets added.
Both make based and meson based build enablement you can add it in that
patch.


>