[dpdk-dev] [PATCH v5 16/31] net/ice: support device and queue ops

[Lu, Wenzhuo]

Hi Ferruh,


> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, December 18, 2018 7:48 AM
> To: Lu, Wenzhuo <wenzhuo.lu at intel.com>; dev at dpdk.org
> Cc: Yang, Qiming <qiming.yang at intel.com>; Li, Xiaoyun
> <xiaoyun.li at intel.com>; Wu, Jingjing <jingjing.wu at intel.com>
> Subject: Re: [dpdk-dev] [PATCH v5 16/31] net/ice: support device and queue
> ops
> 
> On 12/17/2018 7:37 AM, Wenzhuo Lu wrote:
> > Normally when starting/stopping the device the queue should be started
> > and stopped. Support them both in this patch.
> >
> > Below ops are added,
> > dev_configure
> > dev_start
> > dev_stop
> > dev_close
> > dev_reset
> > rx_queue_start
> > rx_queue_stop
> > tx_queue_start
> > tx_queue_stop
> > rx_queue_setup
> > rx_queue_release
> > tx_queue_setup
> > tx_queue_release
> >
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu at intel.com>
> > Signed-off-by: Qiming Yang <qiming.yang at intel.com>
> > Signed-off-by: Xiaoyun Li <xiaoyun.li at intel.com>
> > Signed-off-by: Jingjing Wu <jingjing.wu at intel.com>
> > ---
> >  config/common_base               |   2 +
> >  doc/guides/nics/features/ice.ini |   1 +
> >  doc/guides/nics/ice.rst          |   8 +
> >  drivers/net/ice/Makefile         |   3 +-
> >  drivers/net/ice/ice_ethdev.c     | 198 ++++++++-
> >  drivers/net/ice/ice_lan_rxtx.c   | 927
> +++++++++++++++++++++++++++++++++++++++
> 
> Out of curiosity, why not ice_rxtx.c but "ice_lan_rxtx.c", is that "lan" means
> something?
It’s a good question. I don’t think this 'lan' has any specific meaning. And feel that don't like it either. Will change it to ice_rxtx.c to make it the same as others.