[dpdk-dev] [PATCH] net/ixgbe: fix busy wait in ixgbevf_check_link()

Chas Williams 3chas3 at gmail.com
Thu Feb 1 23:39:07 CET 2018


From: "Charles (Chas) Williams" <chas3 at att.com>

If we haven't set wait_to_complete, there is no need to busy wait until we
have a link status.  Applications, like bonding, use the wait_to_complete
flag to indicate that they will be doing their own busy wait and will
likely be polling again shortly.

Fixes: dc66e5fd01b9 ("net/ixgbe: improve link state check on VF")

Signed-off-by: Chas Williams <chas3 at att.com>
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 37eb668..f6fd1c9 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -3861,7 +3861,7 @@ ixgbevf_check_link(struct ixgbe_hw *hw, ixgbe_link_speed *speed,
 	/* for SFP+ modules and DA cables on 82599 it can take up to 500usecs
 	 * before the link status is correct
 	 */
-	if (mac->type == ixgbe_mac_82599_vf) {
+	if (mac->type == ixgbe_mac_82599_vf && wait_to_complete) {
 		int i;
 
 		for (i = 0; i < 5; i++) {
-- 
2.9.5



More information about the dev mailing list