[dpdk-dev] [PATCH v3] raw/skeleton_rawdev: fix device start test

Shreyansh Jain shreyansh.jain at nxp.com
Mon Feb 5 17:25:59 CET 2018


> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> Sent: Monday, February 5, 2018 7:41 PM
> To: Shreyansh Jain <shreyansh.jain at nxp.com>
> Cc: dev at dpdk.org
> Subject: Re: [PATCH v3] raw/skeleton_rawdev: fix device start test
> 
> 05/02/2018 12:31, Shreyansh Jain:
> > Device can only be started if firmware is loaded, as per Skeleton
> > rawdev driver semantics. This patch fixes original implementation
> > which attempted to start the device without loading firmware.
> >
> > Fixes: 55ca1b0f2151 ("raw/skeleton: add test cases")
> > Cc: shreyansh.jain at nxp.com
> >
> > Signed-off-by: Shreyansh Jain <shreyansh.jain at nxp.com>
> > ---
> > v3:
> >  - Moving 'Fixes' below commit message
> >  - patch headline made specific
> >
> > v2:
> >  - Fixed headline from drivers/raw to raw/skeleton_rawdev
> 
> Actually, it should be raw/skeleton because it is shorter
> and it is what was chosen for previous commits :)

Yes, that is shorter but not correct as per directory name. And, I thought I had made a mistake in previous commit.

In hindsight, my choice for driver name itself was not correct - I had thought of type_subtype but it doesn't sound right now that it is directory. I will change that in next release, I guess.

I will send v4 with 'raw/skeleton'.


More information about the dev mailing list