[dpdk-dev] [PATCH FIX-OPTION-1] mbuf: fix the logic of user mempool ops API

Thomas Monjalon thomas at monjalon.net
Tue Feb 6 01:05:19 CET 2018


02/02/2018 14:40, Olivier Matz:
> On Fri, Feb 02, 2018 at 01:33:01PM +0530, Hemant Agrawal wrote:
> > From: Nipun Gupta <nipun.gupta at nxp.com>
> > 
> > The existing rte_eal_mbuf_default mempool ops can return the compile time
> > default ops name if the user has not provided command line inputs for
> > mempool ops name. It will break the logic of best mempool ops as it will
> > never return platform hw mempool ops.
> > 
> > This patch introduces a new API to just return the user mempool ops only.
> > 
> > Fixes: 8b0f7f434132 ("mbuf: maintain user and compile time mempool ops name")
> > 
> > Signed-off-by: Nipun Gupta <nipun.gupta at nxp.com>
> 
> This option is fine for me. I think we may also consider deprecating
> rte_eal_mbuf_default_mempool_ops(), as it is done in option 2.
> 
> Acked-by: Olivier Matz <olivier.matz at 6wind.com>

Applied, thanks



More information about the dev mailing list