[dpdk-dev] [PATCH v3] doc: update flow filtering document

[Zhao1, Wei]

Hi, Ferruh

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, February 6, 2018 10:19 PM
> To: Mcnamara, John <john.mcnamara at intel.com>; Zhao1, Wei
> <wei.zhao1 at intel.com>; dev at dpdk.org
> Cc: stable at dpdk.org; orika at mellanox.com
> Subject: Re: [dpdk-dev] [PATCH v3] doc: update flow filtering document
> 
> On 2/5/2018 3:31 PM, Mcnamara, John wrote:
> >
> >> -----Original Message-----
> >> From: Yigit, Ferruh
> >> Sent: Wednesday, January 31, 2018 5:24 PM
> >> To: Zhao1, Wei <wei.zhao1 at intel.com>; dev at dpdk.org
> >> Cc: Mcnamara, John <john.mcnamara at intel.com>; stable at dpdk.org;
> >> orika at mellanox.com
> >> Subject: Re: [dpdk-dev] [PATCH v3] doc: update flow filtering
> >> document
> >>
> >> On 1/31/2018 2:12 AM, Wei Zhao wrote:
> >>> This patch will update example application of flow_filtering document.
> >>> It add Tx queues configuration related comment.
> >>>
> >>> Signed-off-by: Wei Zhao <wei.zhao1 at intel.com>
> >>> Reviewed-by: Ori Kam <orika at mellanox.com>
> >>
> >> Hi Wei,
> >>
> >> This patch is causing documentation warning:
> >> ...dpdk/doc/guides/sample_app_ug/flow_filtering.rst:161: WARNING:
> >> Could not lex literal_block as "c". Highlighting skipped.
> >
> > Hi,
> >
> > The reason for the warning was due to 2 instances like the following:
> >
> > +                            rte_exit(EXIT_FAILURE,
> > +                                    ":: Rx queue setup failed: err=%d,
> > +                                    port=%u\n",
> > +                                    ret, port_id);
> >
> >
> > Here the error string extends over 2 lines so the error message will
> > print out a newline and a lot of whitespace in the middle of the string. It
> should probably be something like the following:
> >
> > +                            rte_exit(EXIT_FAILURE,
> > +                                    ":: Rx queue setup failed: err=%d, "
> > +                                    "port=%u\n",
> > +                                    ret, port_id);
> >
> > or just:
> >
> > +                            rte_exit(EXIT_FAILURE,
> > +                                    ":: Rx queue setup failed: err=%d, port=%u\n",
> > +                                    ret, port_id);
> 
> Thanks for clarifying this John.
> 
> Patch pulled from next-net-intel to next-net and suggested fix applied on
> next-net.

Code in next-net-intel has been fixed for this issue, but code in v3  has not.
So, the code you pull from next-net-intel has been changed to 

	rte_exit(EXIT_FAILURE,
		":: Rx queue setup failed: err=%d, port=%u\n",
		ret, port_id);

you can have a double check, maybe it do not need fix patch.