[dpdk-dev] [PATCH] app/testpmd: enable CRC strip without capability check

Ferruh Yigit ferruh.yigit at intel.com
Thu Feb 8 15:29:33 CET 2018


On 2/8/2018 12:13 PM, Ananyev, Konstantin wrote:
> 
> 
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Thursday, February 8, 2018 12:08 PM
>> To: Lu, Wenzhuo <wenzhuo.lu at intel.com>; Wu, Jingjing <jingjing.wu at intel.com>
>> Cc: dev at dpdk.org; Yigit, Ferruh <ferruh.yigit at intel.com>; Thomas Monjalon <thomas at monjalon.net>; Ananyev, Konstantin
>> <konstantin.ananyev at intel.com>; motih at mellanox.com; shahafs at mellanox.com
>> Subject: [PATCH] app/testpmd: enable CRC strip without capability check
>>
>> Some hardware doesn't support disabling CRC strip. In techboard it has
>> been decided to enable CRC strip always.
>>
>> The testpmd update in commit 8b9bd0efe0b6, enables CRC strip only if
>> PMD reports CRC strip capability. Not all PMDs updated to report CRC
>> strip.
>>
>> For the PMDs not reporting CRC strip testpmd behavior changed and
>> disabling CRC strip for them. And this may generate error for PMDs that
>> doesn't support disabling CRC strip.
>>
>> Removing capability check for this release. In long term there can be
>> option to remove CRC strip flag completely or adding a new flag to let
>> PMD say disabling is not supported.
>>
>> Fixes: 8b9bd0efe0b6 ("app/testpmd: disable Rx VLAN offloads by default")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev at intel.com>

Applied to dpdk-next-net/master, thanks.


More information about the dev mailing list