[dpdk-dev] [PATCH v3 1/2] gro: code cleanup

Tan, Jianfeng jianfeng.tan at intel.com
Wed Jan 3 02:07:37 CET 2018



> -----Original Message-----
> From: Richardson, Bruce
> Sent: Tuesday, January 2, 2018 7:26 PM
> To: Hu, Jiayu
> Cc: dev at dpdk.org; Tan, Jianfeng; Chen, Junjie J; Ananyev, Konstantin;
> stephen at networkplumber.org; Yigit, Ferruh; Yao, Lei A
> Subject: Re: [dpdk-dev] [PATCH v3 1/2] gro: code cleanup
> 
> On Fri, Dec 22, 2017 at 03:25:43PM +0800, Jiayu Hu wrote:
> > - Remove needless check and variants
> > - For better understanding, update the programmer guide and rename
> >   internal functions and variants
> > - For supporting tunneled gro, move common internal functions from
> >   gro_tcp4.c to gro_tcp4.h
> > - Comply RFC 6864 to process the IPv4 ID field
> >
> > Signed-off-by: Jiayu Hu <jiayu.hu at intel.com>
> > ---
> >  .../prog_guide/generic_receive_offload_lib.rst     | 246 ++++++++-------
> >  doc/guides/prog_guide/img/gro-key-algorithm.png    | Bin 0 -> 28231
> bytes
> 
> Rather than binary PNG images, please use SVG files (note, real SVG, not
> an SVG file with a binary blob pasted into it).

Based on my limited experience, there is no shortcut for this, but re-draw the picture with tools like visio.

Thanks,
Jianfeng

> 
> Thanks,
> /Bruce



More information about the dev mailing list