[dpdk-dev] [PATCH 9/9] tools: use SPDX tag for Cavium copyright files

Hemant Agrawal hemant.agrawal at nxp.com
Sun Jan 7 09:54:11 CET 2018


On 1/6/2018 5:50 PM, Jerin Jacob wrote:
> Signed-off-by: Jerin Jacob <jerin.jacob at caviumnetworks.com>
> ---
>  devtools/build-tags.sh | 30 ++----------------------------
>  1 file changed, 2 insertions(+), 28 deletions(-)
>
> diff --git a/devtools/build-tags.sh b/devtools/build-tags.sh
> index 942da2bae..d775b17e9 100755
> --- a/devtools/build-tags.sh
> +++ b/devtools/build-tags.sh
> @@ -1,35 +1,9 @@
>  #!/bin/sh -e
>  # Generate tags or gtags or cscope or etags files
>  #
> -#   BSD LICENSE
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2017 Cavium, Inc

Hi Jerin,
        All your patches are ok except this one.
It is not aligned with the policy.
SPDX tag shall be in 1st or 2nd line (for !/bin/sh) scripts.

you can move the comments ("Generate tags...") after the copyrights.

Regards,
Hemant


More information about the dev mailing list