[dpdk-dev] [PATCH v2 5/6] net/failsafe: use ownership mechanism to own ports

[Gaëtan Rivet]

On Mon, Jan 08, 2018 at 11:16:37AM +0000, Matan Azrad wrote:
> Hi Gaetan
> 
> From: Gaëtan Rivet, Sent: Monday, January 8, 2018 12:33 PM
> > Hi Matan,
> > 
> > Thanks for the patches. A remark however:
> > 
> > On Sun, Jan 07, 2018 at 09:45:50AM +0000, Matan Azrad wrote:
> > > Fail-safe PMD sub devices management is based on ethdev port
> > mechanism.
> > > So, the sub-devices management structures are exposed to other DPDK
> > > entities which may use them in parallel to fail-safe PMD.
> > >
> > > Use the new port ownership mechanism to avoid multiple managments of
> > > fail-safe PMD sub-devices.
> > >
> > 
> > I think your implementation does not work with several fail-safe instances,
> > have you tested this configuration?
> > 
> 
> Why not? Each instance calls to fs_eth_dev_create and there the unique owner id allocation is called.
> So, Any instance should get a unique owner id.
>  

Ah, sure, I forgot about the actual owner-id.

No problem then, as you said it should work.

Regarding the fail-safe part:

Acked-by: Gaetan Rivet <gaetan.rivet at 6wind.com>

-- 
Gaëtan Rivet
6WIND