[dpdk-dev] [PATCH v2 15/39] examples/ipsec-secgw: convert to new ethdev offloads API

[Akhil Goyal]

Hi Pablo,

On 1/8/2018 9:57 PM, De Lara Guarch, Pablo wrote:
> 
> 
>> -----Original Message-----
>> From: Shahaf Shuler [mailto:shahafs at mellanox.com]
>> Sent: Thursday, December 21, 2017 1:45 PM
>> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>;
>> dev at dpdk.org; Ananyev, Konstantin <konstantin.ananyev at intel.com>;
>> Nicolau, Radu <radu.nicolau at intel.com>; arybchenko at solarflare.com
>> Subject: RE: [dpdk-dev] [PATCH v2 15/39] examples/ipsec-secgw: convert to
>> new ethdev offloads API
>>
>> Hi Pablo and maintainers of ipsec-secgw,
>>
>> Tuesday, December 19, 2017 2:39 PM, De Lara Guarch, Pablo
>>>> diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-
>>>> secgw/ipsec-secgw.c index c98454a..1e8af8d 100644
>>>> --- a/examples/ipsec-secgw/ipsec-secgw.c
>>>> +++ b/examples/ipsec-secgw/ipsec-secgw.c
>>>> @@ -217,6 +217,9 @@ struct lcore_conf {
>>>>   	},
>>>>   	.txmode = {
>>>>   		.mq_mode = ETH_MQ_TX_NONE,
>>>> +		.offloads = (DEV_TX_OFFLOAD_IPV4_CKSUM |
>>>> +			     DEV_TX_OFFLOAD_MULTI_SEGS |
>>>> +			     DEV_TX_OFFLOAD_MBUF_FAST_FREE),
>>>
>>> Hi Shahaf,
>>>
>>> Isn't this removing some checksums that were previously done?
>>> Txq_flags was set to 0, which means that SCTP, UDP... checksums are
>>> disabled now?
>>
>> You are right that before txqflags were 0, but it doesn't seem the
>> application uses any Tx checksum offload beside IPv4, as seen on snipped
>> code[1].
>> If I was mistaken and it does uses L4 checksums then I will need to update
>> this commit.
>>
>> Maintainers of this examples - can you confirm?
>>
> Akhil, Radu, could you confirm that this change is OK for the IPSec app?
> There is a v3 already of this patch: http://dpdk.org/dev/patchwork/patch/32711/
> 
> Thanks,
> Pablo
> 
I believe Radu is a better person to review this one. It is related to 
ethernet offloads.

-Akhil