[dpdk-dev] [PATCH v3] kni: convert license headers to SPDX tags

[Hemant Agrawal]

On 1/9/2018 9:00 PM, Ferruh Yigit wrote:
> On 1/9/2018 3:24 PM, Thomas Monjalon wrote:
>> 09/01/2018 16:12, Ferruh Yigit:
>>> --- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h
>>> +++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h
>>> +/* SPDX-License-Identifier: (BSD-3-Clause OR LGPL-2.1) */
>>> +/*
>>> + * Copyright(c) 2007-2014 Intel Corporation.
>>>   */
>>
>>> --- a/lib/librte_eal/linuxapp/kni/kni_net.c
>>> +++ b/lib/librte_eal/linuxapp/kni/kni_net.c
>>> +// SPDX-License-Identifier: GPL-2.0
>>> +/*
>>> + * Copyright(c) 2010-2014 Intel Corporation.
>>>   */
>>
>> Why these empty lines between SPDX and Copyright?
>
> For kernel module files I followed Linux style, as "//" comments in .c files.
> I don't have strong opinion about this...
>
>
I think it is just fine to use the Linux style for kernel module based 
code.
Acked-by: Hemant Agrawal <hemant.agrawal at nxp.com>