[dpdk-dev] [PATCH v1] app/testpmd: support command echo in CLI batch loading

Xueming(Steven) Li xuemingl at mellanox.com
Wed Jan 10 09:51:30 CET 2018


> -----Original Message-----
> From: Lu, Wenzhuo [mailto:wenzhuo.lu at intel.com]
> Sent: Wednesday, January 10, 2018 4:36 PM
> To: Xueming(Steven) Li <xuemingl at mellanox.com>
> Cc: Wu, Jingjing <jingjing.wu at intel.com>; dev at dpdk.org; Olivier MATZ
> <olivier.matz at 6wind.com>; Burakov, Anatoly <anatoly.burakov at intel.com>
> Subject: RE: [dpdk-dev] [PATCH v1] app/testpmd: support command echo in
> CLI batch loading
> 
> Hi Xueming,
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Xueming Li
> > Sent: Tuesday, December 26, 2017 10:26 PM
> > Cc: Xueming Li <xuemingl at mellanox.com>; Wu, Jingjing
> > <jingjing.wu at intel.com>; dev at dpdk.org; Olivier MATZ
> > <olivier.matz at 6wind.com>; Burakov, Anatoly <anatoly.burakov at intel.com>
> > Subject: [dpdk-dev] [PATCH v1] app/testpmd: support command echo in
> > CLI batch loading
> >
> > Use first bit of verbose_level to enable CLI echo of batch loading.
> After this patch, the first bit of verbose_level is ambiguous. It can
> still enable/disable the log print.
> Is it by design?
You are correct, there are some code in testpmd simply testing verbose>0.
How about changing all the test to: verbose & 1? I have another patchset
using other bits of verbose...


More information about the dev mailing list