[dpdk-dev] [PATCH v4 1/4] lib/librte_flow_classify: remove table id parameter from apis

Thomas Monjalon thomas at monjalon.net
Wed Jan 10 12:07:21 CET 2018


10/01/2018 11:59, Singh, Jasvinder:
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> > 10/01/2018 10:54, Singh, Jasvinder:
> > > From: Thomas Monjalon [mailto:thomas at monjalon.net]
> > > > 19/12/2017 15:29, Jasvinder Singh:
> > > > > This patch removes table id parameter from all the flow classify
> > > > > apis to reduce the complexity alongwith some code cleanup.
> > > > >
> > > > > The validate api is exposed as public api to allow user to
> > > > > validate the flow before adding it to the classifier.
> > > >
> > > > This patch does not compile alone.
> > > > Should we merge all patches together?
> > >
> > > No, It should compile alone. On my system it doesn't show any error and
> > compilation goes successfully. Could you send me error log, etc ?
> > 
> > test/test/test_flow_classify.c:48:10: fatal error: too many arguments to
> >       function call, expected 6, have 7
> >                         NULL, NULL);
> >                               ^~~~
> > 
> > I guess it is expected that test and example does not compile after patch 1.
> > That's why I suggest to merge all 4 patches.
> 
> Ok, I will send revised patch with all merged into one.

I can merge them myself, it is fine.


More information about the dev mailing list