[dpdk-dev] [PATCH 1/2] mbuf: update default Mempool ops with HW active pool
Hemant Agrawal
hemant.agrawal at nxp.com
Wed Jan 10 13:49:11 CET 2018
Hi Olivier,
>> I just feel it's a bit messy to have:
>>
>> - rte_eal_mbuf_default_mempool_ops() in eal API
>> return user-selected ops if any, or compile-time default
>>
>> - rte_pktmbuf_active_mempool_ops() in mbuf API
>> return platform ops except if a selected user ops != compile default
>>
>> Thomas suggested somewhere (but I don't remember in which thread) to have
>> rte_eal_mbuf_default_mempool_ops() in mbuf code, and I think he was
>> right.
>>
>
> The idea is good. It will break ABI, but we can move around in
> systematic way.
>
>> I think the whole mbuf pool ops selection mechanism should be at the
>> same place. I could be in a specific file of librte_mbuf.
>>
I have just tried to implement your suggestions. I need one clarification.
Eal based internal config is being used to store the command line
mempool_ops_name.
If we want it to be a mbuf based API (instead of eal_mbuf), we need to
export internal_config via map file for shared build.
Are you fine with that?
If not, we have to live with eal_mbuf APIs only.
Regards,
Hemant
More information about the dev
mailing list