[dpdk-dev] [PATCH v4] net/i40e: move RSS to flow API

[Ferruh Yigit]

On 1/10/2018 2:10 AM, Wei Zhao wrote:
> Rte_flow actually defined to include RSS,
> but till now, RSS is out of rte_flow.
> This patch is to move i40e existing RSS to rte_flow.
> This patch also enable queue region configuration
> using flow API for i40e.
> 
> Signed-off-by: Wei Zhao <wei.zhao1 at intel.com>

<...>

> @@ -4269,6 +4597,9 @@ i40e_flow_destroy(struct rte_eth_dev *dev,
>  		ret = i40e_flow_add_del_fdir_filter(dev,
>  		       &((struct i40e_fdir_filter *)flow->rule)->fdir, 0);
>  		break;
> +	case RTE_ETH_FILTER_HASH:
> +		ret = i40e_config_rss_filter_del(dev,
> +			   (struct i40e_rte_flow_rss_conf *)flow->rule);

This is causing build error [1], if the fallback is intentional compiler expects
a /* Fallthrough */ comment.

[1]
.../drivers/net/i40e/i40e_flow.c:4601:7: error: this statement may fall through
[-Werror=implicit-fallthrough=]
   ret = i40e_config_rss_filter_del(dev,

   ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

       (struct i40e_rte_flow_rss_conf *)flow->rule);
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.../drivers/net/i40e/i40e_flow.c:4603:2: note: here

  default:
  ^~~~~~~