[dpdk-dev] [PATCH v6 00/23] eventtimer: introduce event timer adapter

Erik Gabriel Carrillo erik.g.carrillo at intel.com
Thu Jan 11 01:20:51 CET 2018


This patch set adds an initial implementation of the software driver
for the event timer adapter library, adds some unit tests, and adds
documentation.  More testing is needed, but I'd like to get feedback on the
current state.

This patch set produces the following checkpatch warning: 
"macro with flow control". I have left the macros in since such usage seems
common in DPDK.

The tests also depend on the following patch to pass:
http://dpdk.org/ml/archives/dev/2018-January/085209.html

v6
- Addressed comments on previous versin from Jerin:
  - Added RTE_EVENT_TIMER_CANCELED event timer state back in
  - remove check for started adapter in timer arm/cancel functions 
  - reuse CONFIG_RTE_LIBRTE_EVENTDEV_DEBUG instead of adding new config option
- Added initial version of software driver implementation
- Added stats APIs
- Added API to retrieve adapter service ID
- Added API to initialize event timer
- Added entry to Programmer's Guide in documentation
- Added new unit tests to auto-test

v5
- Addressed comments on previous version from Pavan:
  - renamed rte_event_timer_adapter_driver.h to rte_event_timer_adapter_pmd.h
  - moved contents of sw_event_timer_adapter.c into rte_event_timer_adapter.c
  - added flags parameter to timer_adapter_caps_get() call
  - added DEBUG config variable to conditionally compile run-time checks on
    datapath
  - fixed license text and file description
- Also added a config variable to enable/disable compilation of event timer
  adapter - feedback on whether this is desirable is appreciated

v4
- Split changes into multiple patches for easier review

v3
- Reworked allocation and ops organization in common code based on feedback
  received from Jerin and Pavan. This will allow fast-path function pointers to 
  be dereferenced with one level of indirection with pointers valid in primary
  and secondary processes.
- Moved default software implementation from sw_evdev directory to eventdev
  library directory, which will allow it to be used by any eventdev PMD as an
  alternative to providing its own definitions.
- Reverted occurrences of id back to pointer to adapter struct in library API
- Added rte_event_timer_adapter_lookup() function back in

v2
- Added ops structure and stubbed out plugin for SW impl
- Added unit test stubs
- Replaced occurrences of "wheel" in API with "adapter"
- Replaced occurrences of pointer to struct rte_event_timer_adapter with ids
- Removed rte_event_timer_adapter_lookup() function
- Replaced RTE_EVENT_TIMER_SUCCESS_{ARM,CANCEL} states with
  RTE_EVENT_TIMER_ARMED

Erik Gabriel Carrillo (23):
  eventtimer: add event timer adapter API
  eventtimer: add common code
  eventtimer: add default software driver stub
  test: add event timer adapter auto-test
  eventtimer: add adapter allocation definitions
  test: exercise event timer adapter allocation functions
  eventtimer: add adapter get info function definition
  eventtimer: add adapter start/stop definitions
  eventtimer: add API to get service id
  eventtimer: remove service id entry from info structure
  test: exercise event timer adapter start/stop functions
  eventtimer: add event timer arm/cancel function definitions
  eventtimer: add adapter service definition
  eventtimer: add event timer initializer function
  eventtimer: add buffering of timer expiry events
  eventtimer: add stats to API
  eventtimer: add support for single-producer put mode
  eventtimer: add non-blocking mode for event timer operations
  test: exercise event timer arm and expiry
  maintainers: add event timer adapter section
  doc: add event timer adapter to API index
  doc: add event timer adapter section to programmer's guide
  doc: add event timer adapter to release notes

 MAINTAINERS                                       |    6 +
 doc/api/doxy-api-index.md                         |    1 +
 doc/guides/prog_guide/event_timer_adapter.rst     |  301 ++++++
 doc/guides/prog_guide/index.rst                   |    1 +
 doc/guides/rel_notes/release_18_02.rst            |    6 +
 drivers/event/sw/sw_evdev.c                       |   18 +
 lib/Makefile                                      |    2 +-
 lib/librte_eventdev/Makefile                      |    5 +-
 lib/librte_eventdev/rte_event_timer_adapter.c     | 1147 +++++++++++++++++++++
 lib/librte_eventdev/rte_event_timer_adapter.h     |  651 ++++++++++++
 lib/librte_eventdev/rte_event_timer_adapter_pmd.h |  174 ++++
 lib/librte_eventdev/rte_eventdev.h                |    7 +-
 lib/librte_eventdev/rte_eventdev_pmd.h            |   35 +
 lib/librte_eventdev/rte_eventdev_version.map      |   19 +-
 mk/rte.app.mk                                     |    2 +-
 test/test/Makefile                                |    1 +
 test/test/test_event_timer_adapter.c              |  446 ++++++++
 17 files changed, 2816 insertions(+), 6 deletions(-)
 create mode 100644 doc/guides/prog_guide/event_timer_adapter.rst
 create mode 100644 lib/librte_eventdev/rte_event_timer_adapter.c
 create mode 100644 lib/librte_eventdev/rte_event_timer_adapter.h
 create mode 100644 lib/librte_eventdev/rte_event_timer_adapter_pmd.h
 create mode 100644 test/test/test_event_timer_adapter.c

-- 
2.6.4



More information about the dev mailing list