[dpdk-dev] [PATCH v3] bus/pci: fix wrong intr_handle.type with uio_pci_generic

Thomas Monjalon thomas at monjalon.net
Fri Jan 12 01:04:18 CET 2018


10/01/2018 03:32, Zhiyong Yang:
> For virtio legacy device, testpmd startup fails when using uio_pci_generic.
> 
> The issue is caused by invoking the function pci_ioport_map. The correct
> value of intr_handle.type is already set before calling it, we should avoid
> overwriting the default value "RTE_INTR_HANDLE_UNKNOWN" in this function.
> Besides, the removal has no harm to other cases because it is set to 0 by a
> memset on the whole struct during allocation in the function pci_scan_one.
> 
> Such assignments are removed in the meanwhile in pci_uio_map_resource(),
> pci_vfio_map_resource_primary() and pci_vfio_map_resource_secondary() in
> order to keep consistencies and avoid future questions.
> 
> Fixes: 756ce64b1ecd ("eal: introduce PCI ioport API")
> Cc: stable at dpdk.org
> Signed-off-by: Zhiyong Yang <zhiyong.yang at intel.com>

Reviewed-by: Thomas Monjalon <thomas at monjalon.net>

Applied, thanks



More information about the dev mailing list