[dpdk-dev] [PATCH] checkpatches.sh: Add checks for ABI symbol addition

Neil Horman nhorman at tuxdriver.com
Tue Jan 16 01:37:04 CET 2018


On Mon, Jan 15, 2018 at 10:52:25PM +0100, Thomas Monjalon wrote:
> 15/01/2018 20:05, Neil Horman:
> > Recently, some additional patches were added to allow for programmatic
> > marking of C symbols as experimental.  The addition of these markers is
> > dependent on the manual addition of exported symbols to the EXPERIMENTAL
> > section of the corresponding libraries version map file.  The consensus
> > on review is that, in addition to mandating the addition of symbols to
> > the EXPERIMENTAL version in the map, we need a mechanism to enforce our
> > documented process of mandating that addition when they are introduced.
> > To that end, I am proposing this change.  It is an addition to the
> > checkpatches script, which scan incoming patches for additions and
> > removals of symbols to the map file, and warns the user appropriately
> 
> Thanks for working on this.
Sure.

> I won't pretend that I understand anything in this awk script :)
> 
Stephen suggested that I clean it up and document it a bit, which is probably a good idea.

> I think it would be better to put this code in a new script,
> let's say check-symbol-change.sh, and call it in checkpatches.sh.
> It would be just moving functions, add your copyright, and list the new
> script in your MAINTAINERS section "ABI versioning".
Yeah, I can do that.  New version in the AM
Neil

> 


More information about the dev mailing list