[dpdk-dev] [PATCH 08/12 v3] event/dpaa: add dequeue timeout conversion support

[Nipun Gupta]

> -----Original Message-----
> From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com]
> Sent: Tuesday, January 16, 2018 17:21
> To: Nipun Gupta <nipun.gupta at nxp.com>
> Cc: dev at dpdk.org; Sunil Kumar Kori <sunil.kori at nxp.com>; Hemant Agrawal
> <hemant.agrawal at nxp.com>
> Subject: Re: [PATCH 08/12 v3] event/dpaa: add dequeue timeout conversion
> support
> 
> -----Original Message-----
> > Date: Tue, 16 Jan 2018 23:28:01 +0530
> > From: Nipun Gupta <nipun.gupta at nxp.com>
> > To: jerin.jacob at caviumnetworks.com
> > CC: dev at dpdk.org, sunil.kori at nxp.com, hemant.agrawal at nxp.com
> > Subject: [PATCH 08/12 v3] event/dpaa: add dequeue timeout conversion
> support
> > X-Mailer: git-send-email 1.9.1
> >
> > From: Sunil Kumar Kori <sunil.kori at nxp.com>
> >
> > Signed-off-by: Sunil Kumar Kori <sunil.kori at nxp.com>
> > Acked-by: Hemant Agrawal <hemant.agrawal at nxp.com>
> > ---
> >  drivers/event/dpaa/dpaa_eventdev.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/event/dpaa/dpaa_eventdev.c
> b/drivers/event/dpaa/dpaa_eventdev.c
> > index 82362d5..b4b7aed 100644
> > --- a/drivers/event/dpaa/dpaa_eventdev.c
> > +++ b/drivers/event/dpaa/dpaa_eventdev.c
> > @@ -361,6 +361,7 @@
> >  	.port_release       = dpaa_event_port_release,
> >  	.port_link        = dpaa_event_port_link,
> >  	.port_unlink      = dpaa_event_port_unlink,
> > +	.timeout_ticks    = dpaa_event_dequeue_timeout_ticks,
> 
> This patch is almost empty. Please define dpaa_event_dequeue_timeout_ticks()
> in this patch

Hi Jerin,

As dpaa_event_dequeue_timeout_ticks() is used in patch 5/12 (in function
dpaa_event_dev_configure), I would prefer squashing this in the same patch.
Is this okay with you?

Regards,
Nipun

> 
> >  };
> >
> >  static int
> > --
> > 1.9.1
> >