[dpdk-dev] [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD

[De Lara Guarch, Pablo]

Hi Ravi,

> -----Original Message-----
> From: Kumar, Ravi1 [mailto:Ravi1.Kumar at amd.com]
> Sent: Thursday, January 11, 2018 6:37 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>;
> dev at dpdk.org
> Cc: Shippen, Greg <Greg.Shippen at amd.com>
> Subject: RE: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD
> 
> > -----Original Message-----
> >> From: Kumar, Ravi1 [mailto:Ravi1.Kumar at amd.com]
> >> Sent: Wednesday, January 10, 2018 10:30 AM
> >> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>;
> >> dev at dpdk.org
> >> Cc: Shippen, Greg <Greg.Shippen at amd.com>
> >> Subject: RE: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD
> >>
> >> >Hi Ravi,
> >> >
> >> >> -----Original Message-----
> >> >> From: Ravi Kumar [mailto:Ravi1.kumar at amd.com]
> >> >> Sent: Wednesday, January 10, 2018 9:43 AM
> >> >> To: dev at dpdk.org
> >> >> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>
> >> >> Subject: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD
> >> >>
> >> >> Signed-off-by: Ravi Kumar <Ravi1.kumar at amd.com>
> >> >> ---
> >> >
> >> >...
> >> >
> >> >> --- /dev/null
> >> >> +++ b/drivers/crypto/ccp/Makefile
> >> >> @@ -0,0 +1,55 @@
> >> >> +#
> >> >> +#   Copyright(c) 2018 Advanced Micro Devices, Inc.
> >> >> +#   All rights reserved.
> >> >> +#
> >> >
> >> >As Hemant commented, you need to change this full license with SPDX
> >> tags:
> >> >
> >> >http://dpdk.org/ml/archives/dev/2018-January/085510.html
> >> >
> >> >Could you submit a v4 with these changes today?
> >> >
> >> >Thanks,
> >> >Pablo
> >>
> >> Hi Pablo,
> >>
> >> Our legal team is still working on the license. We want to get the
> >> code reviewed in parallel.
> >> I will give you and update later if we can upload the v4 patch with
> >> SPDX tags today.
> >>
> >
> >Ok, I have looked at the overall patchset and it looks ok to me.
> >The only thing that I would change is the title of patch 7/19:
> >I would change it to "crypto/ccp: support sessionless operations".
> >
> >Regards,
> >Pablo
> 
> Hi Pablo,
> 
> Thanks for going through our code. Good to know the code is fine.
> 
> The new changes in licensing policy has introduced some delays as we work
> through the implications and get agreement from the third party.
> 
> We are working on it and will upload the v4 with SPDX license tags as soon
> as possible.
> 

Any news? RC1 will be out on Friday, and the subtree should be close tomorrow evening,
and there will not be more features added after this point.

Thanks,
Pablo

> Regards,
> Ravi
> >
> >> Regards,
> >> Ravi