[dpdk-dev] [PATCH v2] vfio: fix compilation errors in bsdapp

Moti Haimovsky motih at mellanox.com
Wed Jan 17 18:24:15 CET 2018


This patch fixes the following compilation errors in bsdapp
/home/patchWorkOrg/compilation/lib/librte_eal/bsdapp/eal/eal.c:782:5:
error: no previous prototype for function 'rte_vfio_clear_group'
[-Werror,-Wmissing-prototypes]
int rte_vfio_clear_group(int vfio_group_fd)
    ^
/home/patchWorkOrg/compilation/lib/librte_eal/bsdapp/eal/eal.c:782:30:
error: unused parameter 'vfio_group_fd' [-Werror,-Wunused-parameter]
int rte_vfio_clear_group(int vfio_group_fd)
                             ^
Fixes: c564a2a20093 ("vfio: expose clear group function for internal usages")
Cc: Hemant Agrawal <hemant.agrawal at nxp.com>

Signed-off-by: Moti Haimovsky <motih at mellanox.com>
---
V2:
* Added a stub routine instead of including the rte_vfio.h file which is only valid
  in Linux applications
---
 lib/librte_eal/bsdapp/eal/eal.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
index 7239243..04cbd81 100644
--- a/lib/librte_eal/bsdapp/eal/eal.c
+++ b/lib/librte_eal/bsdapp/eal/eal.c
@@ -748,6 +748,7 @@ int rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,
 int rte_vfio_enable(const char *modname);
 int rte_vfio_is_enabled(const char *modname);
 int rte_vfio_noiommu_is_enabled(void);
+int rte_vfio_clear_group(int vfio_group_fd);
 
 int rte_vfio_setup_device(__rte_unused const char *sysfs_base,
 		      __rte_unused const char *dev_addr,
@@ -779,7 +780,7 @@ int rte_vfio_noiommu_is_enabled(void)
 	return 0;
 }
 
-int rte_vfio_clear_group(int vfio_group_fd)
+int rte_vfio_clear_group(__rte_unused int vfio_group_fd)
 {
 	return 0;
 }
-- 
1.8.3.1



More information about the dev mailing list