[dpdk-dev] [PATCH v2 0/6] net/sfc: convert to the new offload API

Andrew Rybchenko arybchenko at solarflare.com
Thu Jan 18 08:02:25 CET 2018


May be it is too late to suggest a new API functions to ethdev,
but hopefully if the idea is accepted, it could be applied in the
current release cycle since these functions are trivial.

I'm not sure that rte_ethdev_version.map is updated correctly
since EXPERIMENTAL tag is present and I don't understand how it
should be handled.

In general for the transition period from old offload API to the
new one it would be useful to convert Tx offloads to/from txq_flags
in rte_eth_dev_info_get() for default_txconf and
rte_eth_tx_queue_info_get(). Unfortunately it was lost during
new offload API patches review. However, it would require testing
for all network PMDs and we decided to follow more conservative
approach and kept code to fill in txq_flags which should be simply
removed when txq_flags are removed.

Cc: Thomas Monjalon <thomas at monjalon.net>
Cc: Ferruh Yigit <ferruh.yigit at intel.com>
Cc: Shahaf Shuler <shahafs at mellanox.com>

---

v2:
 - make new ethdev API experimentatal (map file and function comment)
 - use space instead of TAB after #define for RTE_?X_OFFLOAD_BIT2STR

Ivan Malov (6):
  ethdev: add a function to look up Rx offload names
  ethdev: add a function to look up Tx offload names
  net/sfc: factor out function to report Rx capabilities
  net/sfc: convert to the new Rx offload API
  net/sfc: factor out function to report Tx capabilities
  net/sfc: convert to the new Tx offload API

 drivers/net/sfc/sfc_dp_tx.h             |   2 +
 drivers/net/sfc/sfc_ethdev.c            |  58 ++++++----
 drivers/net/sfc/sfc_port.c              |   5 +-
 drivers/net/sfc/sfc_rx.c                | 128 +++++++++++++++------
 drivers/net/sfc/sfc_rx.h                |   3 +
 drivers/net/sfc/sfc_tx.c                | 194 +++++++++++++++++++++-----------
 drivers/net/sfc/sfc_tx.h                |   4 +
 lib/librte_ether/rte_ethdev.c           |  87 ++++++++++++++
 lib/librte_ether/rte_ethdev.h           |  36 ++++++
 lib/librte_ether/rte_ethdev_version.map |   2 +
 10 files changed, 397 insertions(+), 122 deletions(-)

-- 
2.7.4



More information about the dev mailing list