[dpdk-dev] [PATCH 1/2] net: fix ESP header byte ordering definition

De Lara Guarch, Pablo pablo.de.lara.guarch at intel.com
Fri Jan 19 10:33:20 CET 2018



> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Nélio Laranjeiro
> Sent: Tuesday, January 16, 2018 3:52 PM
> To: Olivier Matz <olivier.matz at 6wind.com>
> Cc: dev at dpdk.org; borisp at mellanox.com
> Subject: Re: [dpdk-dev] [PATCH 1/2] net: fix ESP header byte ordering
> definition
> 
> On Tue, Jan 16, 2018 at 03:24:09PM +0100, Olivier Matz wrote:
> > On Thu, Jan 11, 2018 at 10:15:58AM +0100, Nelio Laranjeiro wrote:
> > > ESP header is defined in the RFC2406 [1] as Big Endian fields it
> > > should use the corresponding types in DPDK as well.
> > >
> > > Fixes: d4b684f7197a ("net: add ESP header to generic flow steering")
> >
> > I wonder if we should really mark this as a fix.
> 
> I also agree, the point is some examples application have started using it as
> CPU order instead of Network order, this patch also needs to be applied in
> stable branch before fixing the code using it.

If you want a patch to be applied in stable branch, don't forget to CC stable at dpdk.org,
and add it under the fixes tag.

Thanks,
Pabo



More information about the dev mailing list