[dpdk-dev] [PATCH] lib/librte_mbuf: remove void * pointer cast
Yang, Zhiyong
zhiyong.yang at intel.com
Fri Jan 19 11:05:00 CET 2018
Drop this one since the patch doesn't follow the convention. I will resend another new one.
Thanks
Zhiyong
> -----Original Message-----
> From: Yang, Zhiyong
> Sent: Friday, January 19, 2018 5:13 PM
> To: dev at dpdk.org
> Cc: thomas at monjalon.net; Yigit, Ferruh <ferruh.yigit at intel.com>; Yang,
> Zhiyong <zhiyong.yang at intel.com>
> Subject: [PATCH] lib/librte_mbuf: remove void * pointer cast
>
> It is unnecessary to cast from void * to struct rte_mbuf *, the change can
> make code more simple.
>
> Signed-off-by: Zhiyong Yang <zhiyong.yang at intel.com>
> ---
> lib/librte_mbuf/rte_mbuf.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index
> a594e4772..2fd4f5ef9 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -896,11 +896,9 @@ rte_mbuf_sanity_check(const struct rte_mbuf *m,
> int is_header); static inline struct rte_mbuf *rte_mbuf_raw_alloc(struct
> rte_mempool *mp) {
> struct rte_mbuf *m;
> - void *mb = NULL;
>
> - if (rte_mempool_get(mp, &mb) < 0)
> + if (rte_mempool_get(mp, (void **)&m) < 0)
> return NULL;
> - m = (struct rte_mbuf *)mb;
> MBUF_RAW_ALLOC_CHECK(m);
> return m;
> }
> --
> 2.13.3
More information about the dev
mailing list