[dpdk-dev] [PATCH] cryptodev: remove duplicated device name length

De Lara Guarch, Pablo pablo.de.lara.guarch at intel.com
Fri Jan 19 11:41:05 CET 2018



> -----Original Message-----
> From: Tomasz Duszynski [mailto:tdu at semihalf.com]
> Sent: Thursday, December 14, 2017 9:28 AM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>
> Cc: Doherty, Declan <declan.doherty at intel.com>;
> jerin.jacob at caviumnetworks.com; jck at semihalf.com; tdu at semihalf.com;
> dima at marvell.com; nsamsono at marvell.com; jianbo.liu at arm.org;
> dev at dpdk.org
> Subject: Re: [PATCH] cryptodev: remove duplicated device name length
> 
> On Wed, Dec 13, 2017 at 03:54:08PM +0000, Pablo de Lara wrote:
> > Two macros were defined in cryptodev, to serve the same
> > purpose: RTE_CRYPTODEV_NAME_LEN (in the config file) and
> > RTE_CRYPTODEV_NAME_MAX_LEN (in the rte_cryptodev.h file).
> > Since the second one is part of the external API, the first one has
> > been removed, avoiding duplications.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>

...

> As for mrvl crypto pmd:
> Acked-by: Tomasz Duszynski <tdu at semihalf.com>

I am aware that this patch is removing a configuration option, that was used
in an internal app (so it could potentially be used in other apps).
This shouldn't be the case, plus this macro is duplicated, so apps and PMDs
should use the macro in the cryptodev header file.

Applied to dpdk-next-crypto.

Pablo



More information about the dev mailing list