[dpdk-dev] [PATCH] build: add support for vendor specific ARM cross builds

Bruce Richardson bruce.richardson at intel.com
Fri Jan 19 17:41:26 CET 2018


On Fri, Jan 19, 2018 at 06:45:08PM +0530, Pavan Nikhilesh wrote:
> Add various vendor specific cross build targets.
> This can be verified by using linaro toolchain and running
> 
> 	meson build --cross-file config/arm/arch64_armv8_<cpu>_cross
> 

"arch64-armv8"? I thought we were standardizing on "arm64" as the naming
here, or alternatively I think it should be "aarch64", right?

In terms of file naming, do we want to have a file extension on these
files. I wondering if we want to change "_cross" to ".cross" for
instance. The basic example in the meson docs uses a .txt extension but
that looks weird to me. No strong opinion on my end, just looking for
any other ideas.

> In future more cross build targets can be added.

Yes, good idea. Is config/<arch> the best place to hold these, or should
we have a separate cross-build folder? I quite like having them in
config like you have done, but wondering if anyone disagrees?

> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula at caviumnetworks.com>
> ---
>  config/arm/arch64_armv8_generic_cross  | 10 +++++++
>  config/arm/arch64_armv8_thunderx_cross | 13 +++++++++
>  config/arm/meson.build                 | 52 +++++++++++++++++++---------------
>  3 files changed, 52 insertions(+), 23 deletions(-)
>  create mode 100644 config/arm/arch64_armv8_generic_cross
>  create mode 100644 config/arm/arch64_armv8_thunderx_cross
> 

Adding Thomas on CC as he always has opinions on file locations and
naming.

/Bruce


More information about the dev mailing list