[dpdk-dev] [PATCH v5 0/6] TAP RSS eBPF cover letter

Ferruh Yigit ferruh.yigit at intel.com
Sat Jan 20 17:15:47 CET 2018


On 1/19/2018 6:48 AM, Pascal Mazon wrote:
> Hi,
> 
> It seems more logical to me to introduce tap_program (patch 3) before
> its compiled version (patch 2).
> Source code is indeed written down before compiling it.
> 
> The doc section is a good addition.
> I'll be happy to see the upcoming utility for turning eBPF bytecode to C
> arrays.
> I'd have liked to see automation code (in a not-executed Makefile target
> typically) for generating the bytecode.
> I'm being told it should happen in the upcoming series along with the
> aforementioned utility.
> 
> Otherwise code looks good enough (I couldn't see everything for lack of
> time), considering that later patches are expected in next release.
> 
> Acked-by: Pascal Mazon <pascal.mazon at 6wind.com>
> 
> Best regards,
> Pascal
> 
> On 18/01/2018 14:38, Ophir Munk wrote:
>> The patches of TAP RSS eBPF follow the RFC on this issue
>> https://dpdk.org/dev/patchwork/patch/31781/
>>
>> v5 changes with respect to v4
>> =============================
>> Update TAP document guide with RSS
>>
>> v4 changes with respect to v3
>> =============================
>> * Code updates based on review comments
>> * New commits organization (2-->5) based on review comments
>>   1. net/tap: support actions for different classifiers (preparations for BPF. 
>>      No BPF code yet)
>>   2. net/tap: add eBPF bytes code (BPF bytes code in a separate file)
>>   3. net/tap: add eBPF program file (Program source code of bytes code)
>>   4. net/tap: add eBPF API (BPF API to be used by TAP)
>>   5. net/tap: implement TAP RSS using eBPF
>>
>> v3 changes with respect to v2
>> =============================
>> * Add support for IPv6 RSS in BPF program
>> * Bug fixes
>> * Updated compatibility to kernel versions:
>>   eBPF requires Linux version 4.9 configured with BPF
>> * New license header (SPDX) for newly added files
>>
>> v2 changes with respect to v1
>> =============================
>> * v2 has new commits organization (3 --> 2)
>> * BPF program was revised. It is successfully tested on
>>   IPv4 L3 L4 layers (compatible to mlx4 device)
>> * Licensing: no comments received for using "Dual BSD/GPL"
>>   string during BPF program loading to the kernel.
>>   (v1 and v2 are using the same license strings)
>>   Any comments are welcome.
>> * Compatibility to kernel versions:
>>   eBPF requires Linux version 4.2 configured with BPF. TAP PMD will
>>   successfully compile on systems with old or non-BPF configured kernels.
>>   During compilation time the required Linux headers are searched for.
>>   If they are not present missing definitions are locally added
>>   (tap_autoconf.h).
>>   If the kernel cannot support a BPF operation - at runtime it will
>>   gracefully reject the netlink message (with BPF) sent to it.
>>
>> Ophir Munk (6):
>>   net/tap: support actions for different classifiers
>>   net/tap: add eBPF bytes code
>>   net/tap: add eBPF program file
>>   net/tap: add eBPF API
>>   net/tap: implement TAP RSS using eBPF
>>   doc: detail new tap RSS feature in guides

Series applied to dpdk-next-net/master, thanks.


More information about the dev mailing list