[dpdk-dev] [PATCHv4 2/5] compat: Add __experimental macro

Thomas Monjalon thomas at monjalon.net
Sun Jan 21 19:37:03 CET 2018


Hi,

I know I should have spotted these comments earlier,
I'm sorry to be late on this review.

13/12/2017 16:17, Neil Horman:
> +#ifndef ALLOW_EXPERIMENTAL_APIS
>  
> +#define __experimental \

These macros should be in the DPDK namespace:
	RTE_ALLOW_EXPERIMENTAL_API (no need of S)
	__rte_experimental

> +__attribute__((deprecated("Symbol is not yet part of stable abi"), \

Nit: s/abi/ABI/


More information about the dev mailing list