[dpdk-dev] [PATCH 3/5] net/mlx5: assert for un-successful memory registration

Shahaf Shuler shahafs at mellanox.com
Tue Jan 23 18:08:21 CET 2018


Memory registration can fail, add the proper assert for such scenario
for it at least to be visible in debug mode.

Signed-off-by: Shahaf Shuler <shahafs at mellanox.com>
Signed-off-by: Xueming Li <xuemingl at mellanox.com>
---
 drivers/net/mlx5/mlx5_rxtx.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h
index 79cdfc793..2934f9fb3 100644
--- a/drivers/net/mlx5/mlx5_rxtx.h
+++ b/drivers/net/mlx5/mlx5_rxtx.h
@@ -589,6 +589,10 @@ mlx5_tx_mb2mr(struct mlx5_txq_data *txq, struct rte_mbuf *mb)
 	if (mr) {
 		rte_atomic32_inc(&mr->refcnt);
 		return mr->lkey;
+	} else {
+		WARN("Failed to register mempool 0x%p(%s)",
+		      (void *)mp, mp->name);
+		assert(mr != NULL);
 	}
 	return (uint32_t)-1;
 }
-- 
2.12.0



More information about the dev mailing list