[dpdk-dev] [PATCH v1] net/vdev_netvsc: remove CFLAGS -std=c11 and -pedantic

Matan Azrad matan at mellanox.com
Wed Jan 24 13:48:12 CET 2018


Hi Ophir

From: Ophir Munk, Wednesday, January 24, 2018 1:20 PM
> In order to guarantee a successful vdev_netvsc compilation on old Linux
> distributions remove CFLAGS -std=c11 and -pedantic Otherwise old GCC
> compilers may complain as follows:
> cc1: error: unrecognized command line option -std=c11
> 
> Signed-off-by: Ophir Munk <ophirmu at mellanox.com>
> ---
>  drivers/net/vdev_netvsc/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/vdev_netvsc/Makefile
> b/drivers/net/vdev_netvsc/Makefile
> index f2b2ac5..45351b8 100644
> --- a/drivers/net/vdev_netvsc/Makefile
> +++ b/drivers/net/vdev_netvsc/Makefile
> @@ -12,7 +12,7 @@ EXPORT_MAP := rte_pmd_vdev_netvsc_version.map  #
> Additional compilation flags.
>  CFLAGS += -O3
>  CFLAGS += -g
> -CFLAGS += -std=c11 -pedantic -Wall -Wextra
> +CFLAGS += -Wall -Wextra
>  CFLAGS += -D_XOPEN_SOURCE=600
>  CFLAGS += -D_BSD_SOURCE
>  CFLAGS += -D_DEFAULT_SOURCE
> --
> 2.7.4

This patch is a fix for compilation issue so it should be with fix title.
Suggestion:
net/vdev_netvsc: fix build using C11 mode and pedantic

Also "Fixes" line should be added.

Thanks,
Matan.


More information about the dev mailing list