[dpdk-dev] [PATCH v7 08/15] net/ixgbe: use rte_eth_linkstatus functions

[Ferruh Yigit]

On 1/23/2018 12:27 PM, Neil Horman wrote:
> On Mon, Jan 22, 2018 at 03:54:51PM -0800, Stephen Hemminger wrote:
>> Use the new helper functions from eth_dev for
>> handling atomic link_info update.
>>
>> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
>>
>> ---
>>  drivers/net/ixgbe/ixgbe_ethdev.c | 96 +++++++---------------------------------
>>  1 file changed, 17 insertions(+), 79 deletions(-)
>>
>> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
>> index 58217680c29c..7b74cbe92c0d 100644
>> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
>> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>> @@ -20,7 +20,6 @@
>>  #include <rte_debug.h>
>>  #include <rte_pci.h>
>>  #include <rte_bus_pci.h>
>> -#include <rte_atomic.h>
>>  #include <rte_branch_prediction.h>
>>  #include <rte_memory.h>
>>  #include <rte_eal.h>
>> @@ -787,58 +786,6 @@ static const struct rte_ixgbe_xstats_name_off rte_ixgbevf_stats_strings[] = {
>>  #define IXGBEVF_NB_XSTATS (sizeof(rte_ixgbevf_stats_strings) /	\
>>  		sizeof(rte_ixgbevf_stats_strings[0]))
>>  
> Getting some build errors here:
> 
> CC igb_ethdev.o
> /home/nhorman/git/dpdk/drivers/net/e1000/igb_ethdev.c: In function ‘eth_igb_stop’:
> /home/nhorman/git/dpdk/drivers/net/e1000/igb_ethdev.c:1510:2: error: implicit declaration of function ‘rte_eth_linkstatus_set’; did you mean ‘rte_eth_xstats_get’? [-Werror=implicit-function-declaration]
>   rte_eth_linkstatus_set(dev, &link);
>   ^~~~~~~~~~~~~~~~~~~~~~
>   rte_eth_xstats_get
> /home/nhorman/git/dpdk/drivers/net/e1000/igb_ethdev.c:1510:2: error: nested extern declaration of ‘rte_eth_linkstatus_set’ [-Werror=nested-externs]
> /home/nhorman/git/dpdk/drivers/net/e1000/igb_ethdev.c: In function ‘eth_igb_interrupt_action’:
> /home/nhorman/git/dpdk/drivers/net/e1000/igb_ethdev.c:2831:3: error: implicit declaration of function ‘rte_eth_linkstatus_get’; did you mean ‘rte_eth_xstats_get’? [-Werror=implicit-function-declaration]
>    rte_eth_linkstatus_get(dev, &link);
> 

Compiles fine for me, any change that you are using old version of dpdk that
driver doesn't use rte_ethdev_driver.h yet which these functions are implemented in?