[dpdk-dev] [PATCH] net/octeontx: disable PMD for old compilers

Ferruh Yigit ferruh.yigit at intel.com
Thu Jan 25 14:58:32 CET 2018


On 1/23/2018 4:22 PM, Pavan Nikhilesh wrote:
> Disable for clang < 4.0 as it doesn't support the following
> arm machine directives:
> 
> .cpu
> 
> This also disables event octeontx as it depends on net octeontx.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula at caviumnetworks.com>

<...>

> @@ -20,3 +20,8 @@ CLANG_MINOR_VERSION := $(shell echo $(CLANG_VERSION) | cut -f2 -d.)
>  ifeq ($(shell test $(CLANG_MAJOR_VERSION)$(CLANG_MINOR_VERSION) -lt 35 && echo 1), 1)
>  	CC_SUPPORTS_Z := false
>  endif
> +
> +ifeq ($(shell test $(CLANG_MAJOR_VERSION)$(CLANG_MINOR_VERSION) -lt 40 && echo 1), 1)
> +	CONFIG_RTE_LIBRTE_OCTEONTX_PMD=d
> +	CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d
> +endif

I remember we did this before but this is ugly.

Can it be done in a generic way that compiler dependencies defined in the PMD
Makefile and during config PMD may be disable based on dependency and
environment. If there is no dependency PMD will not do anything special, does it
make sense?


More information about the dev mailing list