[dpdk-dev] [PATCH v3 1/4] service: move finalize to internal

[Varghese, Vipin]

Moving the function as internal is ok with me.

Acked-by: Vipin Varghese <vipin.varghese at intel.com>

> -----Original Message-----
> From: Van Haaren, Harry
> Sent: Monday, January 29, 2018 5:38 PM
> To: dev at dpdk.org
> Cc: Van Haaren, Harry <harry.van.haaren at intel.com>; thomas at monjalon.net;
> Varghese, Vipin <vipin.varghese at intel.com>
> Subject: [PATCH v3 1/4] service: move finalize to internal
> 
> This commit moves the rte_service_finalize() function to be in the component
> header, and marks it as @internal.
> The function is only called internally by rte_eal_finalize().
> 
> Signed-off-by: Harry van Haaren <harry.van.haaren at intel.com>
> 
> ---
> 
> Cc: thomas at monjalon.net
> Cc: vipin.varghese at intel.com
> ---
>  lib/librte_eal/common/include/rte_service.h           | 11 -----------
>  lib/librte_eal/common/include/rte_service_component.h | 11 +++++++++++
>  2 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/lib/librte_eal/common/include/rte_service.h
> b/lib/librte_eal/common/include/rte_service.h
> index 5e3e3a6..02b1512 100644
> --- a/lib/librte_eal/common/include/rte_service.h
> +++ b/lib/librte_eal/common/include/rte_service.h
> @@ -429,17 +429,6 @@ int32_t rte_service_attr_get(uint32_t id, uint32_t
> attr_id,
>   */
>  int32_t rte_service_attr_reset_all(uint32_t id);
> 
> -/**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice
> - *
> - * Free up the memory that has been initialized. This routine
> - * is to be invoked prior to process termination.
> - *
> - * @retval None
> - */
> -void rte_service_finalize(void);
> -
>  #ifdef __cplusplus
>  }
>  #endif
> diff --git a/lib/librte_eal/common/include/rte_service_component.h
> b/lib/librte_eal/common/include/rte_service_component.h
> index 849c71d..f881ac0 100644
> --- a/lib/librte_eal/common/include/rte_service_component.h
> +++ b/lib/librte_eal/common/include/rte_service_component.h
> @@ -139,4 +139,15 @@ int32_t rte_service_component_runstate_set(uint32_t
> id, uint32_t runstate);
>   */
>  int32_t rte_service_init(void);
> 
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
> + * @internal Free up the memory that has been initialized.
> + * This routine is to be invoked prior to process termination.
> + *
> + * @retval None
> + */
> +void rte_service_finalize(void);
> +
>  #endif /* _RTE_SERVICE_PRIVATE_H_ */
> --
> 2.7.4