[dpdk-dev] [PATCH v4] app/testpmd: do not enable Rx offloads by default

[Lu, Wenzhuo]

Hi Moti,

> -----Original Message-----
> From: Moti Haimovsky [mailto:motih at mellanox.com]
> Sent: Tuesday, January 30, 2018 5:01 PM
> To: Lu, Wenzhuo <wenzhuo.lu at intel.com>; thomas at monjalon.net
> Cc: dev at dpdk.org; Moti Haimovsky <motih at mellanox.com>
> Subject: [PATCH v4] app/testpmd: do not enable Rx offloads by default
> 
> Removed the hardcoded preconfigured Rx offload configuration from
> testpmd and changed the Rx offload command line parameters from disable
> to enable.
> Testers who wish to use these offloads will now have to explicitly write them
> in the command-line when running testpmd.
> 
> Motivation:
> Some PMDs such at the mlx4 may not implement all the offloads.
> After the offload API rework assuming no offload is enabled by default,
>   commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
>   commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") 
As TX mentioned here and I see TX offload also have a default configuration. Is it better to handle TX too in one patch? It may help to track the motivation later.