[dpdk-dev] [PATCH v6] app/testpmd: no Rx or Tx offloads by default

Thomas Monjalon thomas at monjalon.net
Wed Jan 31 18:19:25 CET 2018


31/01/2018 17:59, Moti Haimovsky:
> Removed the hardcoded preconfigured Rx and Tx offload configuration
> from testpmd and changed the Rx offload command line parameters from
> disable to enable.

The description must be updated because v6 does not remove the last
default Tx offload.

> Testers who wish to use these offloads will now have to explicitly
> write them in the command-line when running testpmd.
> The above does not apply to Rx crc-strip and Tx MBUF_FAST_FREE which
> were not removed and are silently dropped in ports that do not
> support them.

Can be added here: It has been decided by the Technical Board.

> Motivation:
> Some PMDs such at the mlx4 may not implement all the offloads.
> After the offload API rework assuming no offload is enabled by default,
>   commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
>   commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") trying
> to enable a not supported offload is clearly an error which will cause
> configuration failing.
> 
> Considering that testpmd is an application to test the PMD, it should
> not fail on a configuration which was not explicitly requested.
> The behavior of this test application is then turned to an opt-in
> model.
> 
> Signed-off-by: Moti Haimovsky <motih at mellanox.com>
> ---
> V6:
> Returned DEV_RX_OFFLOAD_CRC_STRIP and DEV_TX_OFFLOAD_MBUF_FAST_FREE
> as default config values.

Thank you, it reflects what has been decided today in the
Technical Board meeting.
We discussed the need of not having offloads by default in testpmd.
There are only two exceptions for 18.02:
	- Rx CRC strip is often required, and the flag could be completely removed
or reversed in 18.05.
	- Tx fast free could be discussed more.



More information about the dev mailing list