[dpdk-dev] [RFC 1/7] net/af_xdp: new PMD driver

[Stephen Hemminger]

On Tue, 27 Feb 2018 17:33:00 +0800
Qi Zhang <qi.z.zhang at intel.com> wrote:

> struct pmd_internals {
> +	int sfd;
> +	int if_index;
> +	char if_name[0x100];

why not IFNAMSIZ?

> +	struct ether_addr eth_addr;
> +	struct xdp_queue rx;
> +	struct xdp_queue tx;
> +	struct xdp_umem *umem;
> +	struct rte_mempool *mb_pool;
> +
> +	unsigned long rx_pkts;
> +	unsigned long rx_bytes;
> +	unsigned long rx_dropped;
> +
> +	unsigned long tx_pkts;
> +	unsigned long err_pkts;
> +	unsigned long tx_bytes;

why not per-queue stats? per-port stats are expensive

> +	uint16_t port_id;
> +	uint16_t queue_idx;
> +	int ring_size;
> +	struct rte_ring *buf_ring;
> +};